use pengutronix-hosted runner #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to name it after the layer and build.yml can be consistent with other layers. Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
We don't want apt to install recommended packages or ask for confirmation. Signed-off-by: Jan Luebbe <[email protected]>
This improves performance when building on prepared runners. Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
hnez
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
This looks good to me. Can't wait to see the CI run speed ups in practice.
I've left one comment regarding the use of || true in the caching step, but my suggested change changes the behavior (the second rsync wouldn't run if the first one fails), so it would be okay to me if you do not want to apply it.
Emantor
approved these changes
Aug 27, 2024
|
backported and adapted for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.