Port CI to GitHub Actions and miscellaneous maintenance work #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bastian Krause <[email protected]>
`git describe` will fail if no tags are available. This happens with clones without tags, e.g. `git clone --no-tags [...]`, forks without tags and is the default of actions/checkout@v4 [1]. Add the `--always` option to `git describe` to show the "uniquely abbreviated commit object as fallback" [2]. [1] https://github.com/actions/checkout/blob/v4/README.md#usage [2] https://git-scm.com/docs/git-describe#Documentation/git-describe.txt---always Signed-off-by: Bastian Krause <[email protected]>
Since tox 4, "packaging environments no longer inherit their settings from the testenv section" [1]. This becomes an issue for flamingo because the environment variable FLAMINGO_TEST is checked in its setup.py. Fix this by moving the setenv directive to the build environment section. passenv= in flamingo is not affected because other env lookups are performed outside of its setup.py. [1] https://tox.wiki/en/4.11.3/upgrading.html#packaging-configuration-and-inheritance Signed-off-by: Bastian Krause <[email protected]>
Testing with Python 3.6 has been dropped a while ago, while Python 3.10 testing was added. Advertise these versions and adjust the tox environments accordingly. Fixes: ae476f3 (".travis: Python versions update") Signed-off-by: Bastian Krause <[email protected]>
Fix warnings emitted by `tox -e lint`. Use recommendations from black [1] for affected lines only. [1] https://github.com/psf/black Signed-off-by: Bastian Krause <[email protected]>
Signed-off-by: Bastian Krause <[email protected]>
Signed-off-by: Bastian Krause <[email protected]>
While at it, drop the sample comment and name the workflow accordingly. This gets displayed unter the "actions" tab as well as on the status badge. Signed-off-by: Bastian Krause <[email protected]>
Drop the now unused Travis and LGTM badges. Add badges for GitHub actions CI and documentation build tests. Signed-off-by: Bastian Krause <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 51.44% 50.78% -0.66%
==========================================
Files 66 66
Lines 4078 4125 +47
Branches 785 819 +34
==========================================
- Hits 2098 2095 -3
- Misses 1778 1822 +44
- Partials 202 208 +6
☔ View full report in Codecov by Sentry. |
SmithChart
approved these changes
Oct 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the Travis CI instructions to GitHub Actions. Also allow running the tests with recent tox versions and prepare them to run on forks without tags (i.e. for PRs).
While at it, add Python 3.11 support, fix some linter warnings and typos, update the badges in the README.