This repository has been archived by the owner on Oct 1, 2021. It is now read-only.
Make prepare_request() asynchronous #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why make asynchronous a function that not have any async thing |
|
Because other developers can write their auth_backend and there may be calls to asynchronous functions. |
|
hi @andrew-ld, looks good to me. could you add your comment on why you want this method to be async to your commit message? |
It is necessary to call asynchronous functions. For example, getting permissions from a database (using an asynchronous driver) to check access to methods.
michael-sulyak
force-pushed
the
async-prepare-requests
branch
from
cd57d7a to
efdc0a5
Compare
|
@fscherf done |
|
@expert-m thx! I will merge your pr in the next release. Currently your patch will break the django login backend which has no tests currently, but is a very critical piece of code for my company. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.