Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/gofiber/fiber/v2 to v2.52.5 [security] - autoclosed #41

Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 22, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/gofiber/fiber/v2 v2.50.0 -> v2.52.5 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-25124

The CORS middleware allows for insecure configurations that could potentially expose the application to multiple CORS-related vulnerabilities. Specifically, it allows setting the Access-Control-Allow-Origin header to a wildcard ("*") while also having the Access-Control-Allow-Credentials set to true, which goes against recommended security best practices.

Impact

The impact of this misconfiguration is high as it can lead to unauthorized access to sensitive user data and expose the system to various types of attacks listed in the PortSwigger article linked in the references.

Proof of Concept

The code in cors.go allows setting a wildcard in the AllowOrigins while having AllowCredentials set to true, which could lead to various vulnerabilities.

Potential Solution

Here is a potential solution to ensure the CORS configuration is secure:

func New(config ...Config) fiber.Handler {
    if cfg.AllowCredentials && cfg.AllowOrigins == "*" {
        panic("[CORS] Insecure setup, 'AllowCredentials' is set to true, and 'AllowOrigins' is set to a wildcard.")
    }
    // Return new handler goes below
}

The middleware will not allow insecure configurations when using `AllowCredentials` and `AllowOrigins`.

Workarounds

For the meantime, users are advised to manually validate the CORS configurations in their implementation to ensure that they do not allow a wildcard origin when credentials are enabled. The browser fetch api, browsers and utilities that enforce CORS policies are not affected by this.

References

MDN Web Docs on CORS Errors
CodeQL on CORS Misconfiguration
PortSwigger on Exploiting CORS Misconfigurations
WhatWG CORS protocol and credentials

CVE-2024-38513

A security vulnerability has been identified in the Fiber session middleware where a user can supply their own session_id value, leading to the creation of a session with that key.

Impact

The identified vulnerability is a session middleware issue in GoFiber versions 2 and above. This vulnerability allows users to supply their own session_id value, resulting in the creation of a session with that key. If a website relies on the mere presence of a session for security purposes, this can lead to significant security risks, including unauthorized access and session fixation attacks. All users utilizing GoFiber's session middleware in the affected versions are impacted.

Patches

The issue has been addressed in the latest patch. Users are strongly encouraged to upgrade to version 2.52.5 or higher to mitigate this vulnerability.

Workarounds

Users who are unable to upgrade immediately can apply the following workarounds to reduce the risk:

  1. Validate Session IDs: Implement additional validation to ensure session IDs are not supplied by the user and are securely generated by the server.
  2. Session Management: Regularly rotate session IDs and enforce strict session expiration policies.

References

For more information on session best practices:

Users are encouraged to review these references and take immediate action to secure their applications.


Release Notes

gofiber/fiber (github.com/gofiber/fiber/v2)

v2.52.5

Compare Source

👮 Security
Middleware/session: Session Middleware Token Injection Vulnerability - GHSA-98j2-3j3p-fw2v

https://docs.gofiber.io/api/middleware/session

🧹 Updates
  • Middleware/session: Remove extra release and aquire ctx calls in session_test.go (#​3043)
🐛 Bug Fixes
  • Middleware/monitor: middleware reporting of CPU usage (#​2984)
  • Middleware/session: mutex for thread safety (#​3050)
📚 Documentation
  • Improve ctx.Locals method description and example (#​3030)
  • Improve ctx.Locals method documentation (#​3033)
  • Update README_id.md (#​3045)

Full Changelog: gofiber/fiber@v2.52.4...v2.52.5

Thank you @​nyufeng, @​PaulTitto and @​sixcolors for making this update possible.

v2.52.4

Compare Source

🐛 Fixes

Full Changelog: gofiber/fiber@v2.52.3...v2.52.4

v2.52.3

Compare Source

🐛 Fixes

Full Changelog: gofiber/fiber@v2.52.2...v2.52.3

v2.52.2

Compare Source

🐛 Fixes

Full Changelog: gofiber/fiber@v2.52.1...v2.52.2

v2.52.1

Compare Source

👮 Security

Middleware/cors: Insecure CORS Configuration Allowing Wildcard Origin with Credentials - GHSA-fmg4-x8pw-hjhg

https://docs.gofiber.io/api/middleware/cors

🐛 Fixes

  • Middleware/healthcheck: Not working with route group(#​2863)

📚 Documentation

  • Fix default value to false in docs of QueryBool (#​2811)
  • Fix code snippet indentation in /docs/api/middleware/keyauth.md (#​2867)

Full Changelog: gofiber/fiber@v2.52.0...v2.52.1

Thank you @​luk3skyw4lker, @​CAEL0, @​grivera64, @​gaby and @​sixcolors for making this update possible.

v2.52.0

Compare Source

🚀 New

// Direct usage with default config
app.Use(healthcheck.New())

// Or extend your config for customization
app.Use(healthcheck.New(healthcheck.Config{
    LivenessEndpoint: "/live",
    LivenessProbe: func(c *fiber.Ctx) bool {
        return true
    },
    ReadinessEndpoint: "/ready",
    ReadinessProbe: func(c *fiber.Ctx) bool {
        return serviceA.Ready() && serviceB.Ready() && ...
    },
}))

🧹 Updates

  • Middlewares: don't constrain middlewares context-keys to strings (#​2751)
  • Middleware/logger: colorize logger error message #​2593 (#​2773)
  • Middleware/logger: changing default log output (#​2730)
  • Middleware/logger: log client IP address by default (#​2755)
  • Middleware/encryptcookie: update default config (#​2753)
  • Improve benchmarks for getOffer (#​2739)

🛠️ Maintenance

  • Bump github/codeql-action from 2 to 3 (#​2763)
  • Bump github.com/google/uuid from 1.4.0 to 1.5.0 (#​2762)
  • Bump actions/setup-go from 4 to 5 (#​2754)
  • Bump golang.org/x/sys from 0.14.0 to 0.15.0 (#​2744)
  • Bump github.com/valyala/fasthttp from 1.50.0 to 1.51.0 (#​2721)

🐛 Fixes

  • Middleware/redirect : fix for redirect with query params (#​2748)
  • Middleware/adaptor: Adaptor + otelfiber issue #​2641 (#​2772)
  • Middleware/cors: Should use the defined AllowedOriginsFunc config when AllowedOrigins is empty (#​2771)
  • Middleware/session: Race in session middleware tests (#​2740)
  • Middleware/csrf: Fix failing CSRF tests (#​2720)
  • Fix race condition in parallel tests (#​2734)
  • utils.IsIPv4 and net.ParseIP have inconsistent results #​2735 (#​2736)

📚 Documentation

Full Changelog: gofiber/fiber@v2.51.0...v2.52.0

Thank you @​MehmetFiratKomurcu, @​benjajaja, @​brunodmartins, @​gilwo, @​iredmail, @​itswcg, @​luk3skyw4lker, @​muhammadkholidb, @​nickajacks1, @​sixcolors and @​tokelo-12 for making this update possible.

v2.51.0

Compare Source

🚀 New

// Consideration of parameters in the accepted headers
// Accept: text/plain, application/json; version=1; foo=bar

app.Get("/", func(c *fiber.Ctx) error {
  // Extra parameters in the accept are ignored
  c.Accepts("text/plain;format=flowed") // "text/plain;format=flowed"

  // An offer must contain all parameters present in the Accept type
  c.Accepts("application/json") // ""

  // Parameter order and capitalization does not matter. Quotes on values are stripped.
  c.Accepts(`application/json;foo="bar";VERSION=1`) // "application/json;foo="bar";VERSION=1"
})
// Passing a custom json type
ctx.JSON(fiber.Map{
    "type": "https://example.com/probs/out-of-credit",
    "title": "You do not have enough credit.",
    "status": 403,
    "detail": "Your current balance is 30, but that costs 50.",
    "instance": "/account/12345/msgs/abc",
  }, fiber.)

🧹 Updates

  • Ctx.Range: reduce allocations (#​2705)
  • Middleware/pprof: improve performance (#​2709)

🛠️ Maintenance

  • Bump golang.org/x/sys from 0.13.0 to 0.14.0 (#​2707)
  • Bump github.com/google/uuid from 1.3.1 to 1.4.0 (#​2693)
  • Bump actions/setup-node from 3 to 4 (#​2690)
  • Bump github.com/mattn/go-isatty from 0.0.19 to 0.0.20 (#​2679)

🐛 Fixes

  • Middleware/limiter: fix intermittent failures (#​2716)
  • Naming of routes works wrong after mount #​2688 (#​2689)
  • Fix method validation on route naming (#​2686)

📚 Documentation

  • Changed "Twitter" to "X (Twitter)" in README.md Contribute Section (#​2696)
  • Add additional information as to why GetReqHeaders returns a map where the values are slices of strings (#​2698)
  • Enhance csrf.md (#​2692)

Full Changelog: gofiber/fiber@v2.50.0...v2.51.0

Thank you @​BandhiyaHardik, @​database64128, @​efectn, @​moritz157, @​nickajacks1, @​rhburt and @​sixcolors for making this update possible.


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/go-github.com/gofiber/fiber/v2-vulnerability branch from 4881e40 to f60b8b7 Compare July 1, 2024 22:41
@renovate renovate bot changed the title fix(deps): update module github.com/gofiber/fiber/v2 to v2.52.1 [security] fix(deps): update module github.com/gofiber/fiber/v2 to v2.52.5 [security] Jul 1, 2024
Copy link
Contributor Author

renovate bot commented Jul 1, 2024

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 5 additional dependencies were updated

Details:

Package Change
github.com/google/uuid v1.3.1 -> v1.5.0
github.com/klauspost/compress v1.16.7 -> v1.17.0
github.com/mattn/go-isatty v0.0.19 -> v0.0.20
github.com/valyala/fasthttp v1.50.0 -> v1.51.0
golang.org/x/sys v0.13.0 -> v0.15.0

@renovate renovate bot changed the title fix(deps): update module github.com/gofiber/fiber/v2 to v2.52.5 [security] fix(deps): update module github.com/gofiber/fiber/v2 to v2.52.5 [security] - autoclosed Aug 6, 2024
@renovate renovate bot closed this Aug 6, 2024
@renovate renovate bot deleted the renovate/go-github.com/gofiber/fiber/v2-vulnerability branch August 6, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants