Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

420 change github workflow to run test with feature flags #488

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
e1fe87c
restructure imports for update, relevant modifications of chain exten…
gianfra-t Jul 31, 2024
a791b8e
WIP fixing std issue
gianfra-t Aug 7, 2024
44baf50
modification toml pendulum, orml-currencies, amplitude
gianfra-t Aug 7, 2024
987bbfc
adding pallets to sibling chain
gianfra-t Aug 19, 2024
66aeaf2
compile sibling tests with emulator macros, fixing tests
gianfra-t Aug 19, 2024
fa6b17c
remove .txt files
gianfra-t Aug 21, 2024
553e7f6
Revert "format nightly for latest changes"
gianfra-t Aug 27, 2024
c262c7a
generate weights for dia-oracle pallet
gianfra-t Aug 28, 2024
c66910f
re-introduce non local definition flag for clippy
gianfra-t Aug 29, 2024
fe60e2d
remove temporary dia-oracle fix branch
gianfra-t Aug 29, 2024
816e908
run fmt nightly
gianfra-t Sep 3, 2024
a52e892
add benchmarkings (those not failed), modify config to use default we…
gianfra-t Sep 11, 2024
7b10533
Revert "add benchmarkings (those not failed), modify config to use de…
gianfra-t Sep 11, 2024
cdf430d
fix benchmark for orml-tokens-management, add benchmark helper script…
gianfra-t Sep 11, 2024
99992e6
initial push. Does not
b-yap Jul 24, 2024
bf5ef6e
fix https://github.com/pendulum-chain/pendulum/actions/runs/100769855…
b-yap Jul 26, 2024
0f2896a
rebase with polkadot-v1.1.0; removed mocktopus
b-yap Sep 9, 2024
007381a
fix unimplemented runtime-benchmarks
b-yap Sep 10, 2024
e6427cf
fix invalid array
b-yap Sep 10, 2024
ae3e39b
fix unimplemented traits and run in workflow
b-yap Sep 10, 2024
839684f
https://github.com/pendulum-chain/pendulum/pull/488#issuecomment-2343…
b-yap Sep 12, 2024
fbe53ef
run workflow on edited
b-yap Sep 12, 2024
9057f2b
do not specify type or branch
b-yap Sep 12, 2024
747616d
completely remove nightly
b-yap Sep 12, 2024
1fb9a23
https://github.com/pendulum-chain/pendulum/actions/runs/10827044810/j…
b-yap Sep 13, 2024
1c4f8e5
set the features, remove `--all`
b-yap Sep 13, 2024
27b8c03
integration-test does not need the `runtime-benchmarks` and `try-runt…
b-yap Sep 13, 2024
7f42598
rename the workflow name
b-yap Sep 13, 2024
13cb020
revert to ubuntu-20
b-yap Sep 13, 2024
24814ee
clear disk space
b-yap Sep 16, 2024
c5dacb5
add back the accidentally deleted checkout
b-yap Sep 16, 2024
de2fced
revert to latest because of https://github.com/rust-lang/rustup/issue…
b-yap Sep 16, 2024
fe498b1
reapply the other cleans
b-yap Sep 16, 2024
a788bc2
fix CI
b-yap Sep 17, 2024
5ff9f58
remove bandersnatch
b-yap Sep 17, 2024
dc61d7a
revert from https://github.com/pendulum-chain/pendulum/pull/488/commi…
b-yap Sep 17, 2024
40f0e15
rebase and fix yml files.
b-yap Oct 22, 2024
1cd5e1b
fix issues unrelated to this ticket
b-yap Oct 22, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions .github/actions/shared/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,24 @@ runs:
df -h
shell: bash

- name: Install package
# Free GitHub Actions Environment Disk Space
- name: Maximize Build Space
uses: jlumbroso/free-disk-space@main
with:
tool-cache: false
large-packages: false

# Steps taken from https://github.com/actions/runner-images/issues/7192#issuecomment-1446766800
- name: Disable Phase Updates
shell: bash
run: |
echo 'APT::Get::Always-Include-Phased-Updates "false";' | sudo tee /etc/apt/apt.conf.d/99-phased-updates
sudo apt-get update && sudo apt-get upgrade -y
sudo apt-get install -y protobuf-compiler libprotobuf-dev

- name: Update, Upgrade, and Install Protobuf
shell: bash
run: |
sudo apt-get update && sudo apt-get upgrade -y
sudo apt-get install -y protobuf-compiler libprotobuf-dev

# Steps taken from https://github.com/actions/cache/blob/master/examples.md#rust---cargo
- name: Cache cargo registry
Expand Down
38 changes: 38 additions & 0 deletions .github/workflows/clippy-checks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Clippy Checks

on:
pull_request:
push:
branches:
- main

jobs:
clippy-checks:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Free up Space and Installation
uses: ./.github/actions/shared

- name: Clippy -- Main
uses: actions-rs/cargo@v1
with:
command: clippy
args: --release --all-features -- -W clippy::all -A clippy::style -A forgetting_copy_types -A forgetting_references

- name: Clippy -- All Targets (except integration)
uses: actions-rs/cargo@v1
with:
command: clippy
# We are a bit more forgiving when it comes to the code in tests and only check for correctness
args: --release --workspace --all-features --all-targets --exclude runtime-integration-tests -- -A clippy::all -W clippy::correctness -A forgetting_copy_types -A forgetting_references

- name: Clippy -- Integration
uses: actions-rs/cargo@v1
with:
command: clippy
# We are a bit more forgiving when it comes to the code in tests and only check for correctness
args: --release --package runtime-integration-tests --all-features --all-targets -- -A clippy::all -W clippy::correctness -A forgetting_copy_types -A forgetting_references

47 changes: 7 additions & 40 deletions .github/workflows/test-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ name: Test Code

on:
pull_request:
branches:
- main
push:
branches:
- main
Expand All @@ -16,23 +14,11 @@ jobs:
RUSTFLAGS: "-Dwarnings"

steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/shared

- name: Remove rust-toolchain.toml
# To make sure that the nightly version will be used all throughout
run: |
rm /home/runner/work/pendulum/pendulum/rust-toolchain.toml
- name: Checkout
uses: actions/checkout@v4

- name: Setup nightly Rust toolchain
uses: dtolnay/rust-toolchain@nightly
with:
toolchain: nightly-2024-05-30
components: rustfmt, clippy
target: wasm32-unknown-unknown

- name: Setup nightly Rust as default
run: rustup default nightly-2024-05-30
- name: Free up Space and Installation
uses: ./.github/actions/shared

- name: Install Protoc
uses: arduino/setup-protoc@v1
Expand All @@ -42,30 +28,11 @@ jobs:
- name: Test
uses: actions-rs/cargo@v1
with:
toolchain: nightly-2024-05-30
command: test
args: --release

- name: Clippy -- Main
uses: actions-rs/cargo@v1
with:
toolchain: nightly-2024-05-30
command: clippy
args: --release --all-features -- -W clippy::all -A clippy::style -A forgetting_copy_types -A forgetting_references

- name: Clippy -- All Targets (except integration)
uses: actions-rs/cargo@v1
with:
toolchain: nightly-2024-05-30
command: clippy
# We are a bit more forgiving when it comes to the code in tests and only check for correctness
args: --workspace --release --all-features --all-targets --exclude runtime-integration-tests -- -A clippy::all -W clippy::correctness -A forgetting_copy_types -A forgetting_references

- name: Clippy -- Integration
- name: Test for Runtime Benchmarks
uses: actions-rs/cargo@v1
with:
toolchain: nightly-2024-05-30
command: clippy
# We are a bit more forgiving when it comes to the code in tests and only check for correctness
args: --package runtime-integration-tests --release --all-features --all-targets -- -A clippy::all -W clippy::correctness -A forgetting_copy_types -A forgetting_references

command: test
args: --release --features=runtime-benchmarks,try-runtime
75 changes: 34 additions & 41 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading