-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced CurrencyId enum by Spacewalk Primitives CurrencyId. #272
Replaced CurrencyId enum by Spacewalk Primitives CurrencyId. #272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just left some nit-picky comments on how I would prefer the import structure to be.
I know that the PendulumCurrencyId
is something that existed before and you just adapted the code to that @adelarja, but while reading through the changes I realized that having that extra type might not be ideal. Again, it's quite minor. Rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for addressing my comments @adelarja. Looks good to me now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections. Looks good.
This PR aims to replace the
CurrencyId
enum from pendulum's runtime, with theCurrencyId
enum from the spacewalk primitives.We need to do this in order to implement the ZenlinkProtocol Runtime API for pendulum chain in this PR.
zenlink_id_to_currency_id function will be used for the ZenlinkProtocol Runtime API to convert between zenlink assets to spacewalk currencies. The current implementation will be replaced by the same implementation of the zenlink runtime common module which was used for Amplitude and Foucoco in the previous PR.