Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar improvements #9

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Sidebar improvements #9

merged 8 commits into from
Jun 14, 2024

Conversation

neillrobson
Copy link
Collaborator

The sidebar search functionality is now implemented!

Additionally:

  • Homepage search bar has been removed, and note added to README to implement once some of the top-level "category" pages have been created.
  • Navbar items are now generated from a simple array, rather than hard-coded in the HTML template. Should make it much easier to add and move around sections.
  • General updates to the README for readability and clarity.
  • Added some code formatting standards (.prettierrc). They aren't enforced, but it helps me keep the code consistent and readable.

@neillrobson
Formatting
4bacefb
@neillrobson
Build nav dynamically
76d2cb0
@neillrobson
Initial search functionality
774ff1c 
The sections don't auto-expand when searching begins, making the
experience a little weird.
@neillrobson
Auto-expand/collapse on search
41e56c3 
The old expand/collapse state is cached when a search begins, and then
restored if the search is ever cleared.

I don't love the UX, but it's the best alternative I could think of.
@neillrobson
Remove homepage search, add TODO
3155029
@neillrobson neillrobson added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 13, 2024
@neillrobson neillrobson requested a review from carriependo June 13, 2024 18:35
@neillrobson neillrobson force-pushed the sidebar-improvements branch from 7509a7a to abc6317 Compare June 13, 2024 18:43
@neillrobson neillrobson temporarily deployed to google-cloud-storage June 13, 2024 18:43 — with GitHub Actions Inactive
@neillrobson neillrobson temporarily deployed to google-cloud-storage June 14, 2024 13:31 — with GitHub Actions Inactive
@neillrobson neillrobson merged commit fee8d02 into main Jun 14, 2024
2 checks passed
@neillrobson neillrobson deleted the sidebar-improvements branch June 14, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carriependo carriependo Awaiting requested review from carriependo

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@neillrobson