carlota #9
Open
carlota #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomw-1
approved these changes
Mar 8, 2022
|
|
||
| defer client.Close() | ||
|
|
||
| name := strings.ReplaceAll(params["name"], "%20"," ") |
There was a problem hiding this comment.
https://pkg.go.dev/net/url#QueryUnescape would do this for all url encoded chars, rather than just replacing %20 with a space
| w.WriteHeader(http.StatusBadRequest) | ||
| return | ||
| } | ||
| HandleError(err, w) |
There was a problem hiding this comment.
I don't think HandleError needs to be a public method (starting with a H rather than a h).
If err was an error, it would write the error and set the header, but continue on with the rest of the method anyway. You would probably have to move the if block from the handleError method up to this call and have the handleError then write the response and the header
if err != nil {
handleError(err, w)
return
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.