#1792 Autoswitch to Move tool after selecting

app/src/toolbox.cpp

@@ -31,6 +31,8 @@ GNU General Public License for more details.
 #include "toolmanager.h"
 #include "layermanager.h"
 #include "pencilsettings.h"
+#include "selectionmanager.h"
+#include "selecttool.h"
 
 // ----------------------------------------------------------------------------------
 QString GetToolTips(QString strCommandName)
@@ -137,6 +139,8 @@ void ToolBoxWidget::initUI()
 
     connect(editor()->layers(), &LayerManager::currentLayerChanged, this, &ToolBoxWidget::onLayerDidChange);
 
+    //switch to move tool when selection changes
+    connect(editor()->select(), &SelectionManager::selectionChanged, this, &ToolBoxWidget::onSelectionChanged);
 
     FlowLayout* flowlayout = new FlowLayout;
 
@@ -304,3 +308,18 @@ void ToolBoxWidget::onLayerDidChange(int)
         moveOn();
     }
 }
+
+void ToolBoxWidget::onSelectionChanged(){
+    BaseTool* currentTool = editor()->tools()->currentTool();
+    if (currentTool->type() == SELECT)
+    {
+        if (editor()->select()->somethingSelected())
+        {
+            SelectTool* selectTool = (SelectTool*) currentTool;
+            if (selectTool->properties.autoSwitchTool && !selectTool->selectChanging())
+            {
+                moveOn();
+            }
+        }
+    }
+}

app/src/toolbox.h

@@ -46,6 +46,7 @@ class ToolBoxWidget : public BaseDockWidget
 public slots:
     void onToolSetActive(ToolType toolType);
     void onLayerDidChange(int index);
+    void onSelectionChanged();
     void pencilOn();
     void eraserOn();
     void selectOn();

app/src/tooloptionwidget.cpp

@@ -114,6 +114,8 @@ void ToolOptionWidget::makeConnectionToEditor(Editor* editor)
 
     connect(ui->fillContourBox, &QCheckBox::clicked, toolManager, &ToolManager::setUseFillContour);
 
+    connect(ui->autoSwitchToolCheckBox, &QCheckBox::clicked, toolManager, &ToolManager::setAutoSwitchTool);
+
     connect(ui->showInfoBox, &QCheckBox::clicked, toolManager, &ToolManager::setShowSelectionInfo);
 
     connect(toolManager, &ToolManager::toolChanged, this, &ToolOptionWidget::onToolChanged);
@@ -136,6 +138,7 @@ void ToolOptionWidget::onToolPropertyChanged(ToolType, ToolPropertyType ePropert
     case ANTI_ALIASING: setAA(p.useAA); break;
     case STABILIZATION: setStabilizerLevel(p.stabilizerLevel); break;
     case FILLCONTOUR: setFillContour(p.useFillContour); break;
+    case AUTOSWITCHTOOL: setAutoSwitchTool(p.autoSwitchTool); break;
     case SHOWSELECTIONINFO: setShowSelectionInfo(p.showSelectionInfo); break;
     case BEZIER: setBezier(p.bezier_state); break;
     case CAMERAPATH: { break; }
@@ -186,6 +189,7 @@ void ToolOptionWidget::setVisibility(BaseTool* tool)
     ui->stabilizerLabel->setVisible(tool->isPropertyEnabled(STABILIZATION));
     ui->inpolLevelsCombo->setVisible(tool->isPropertyEnabled(STABILIZATION));
     ui->fillContourBox->setVisible(tool->isPropertyEnabled(FILLCONTOUR));
+    ui->autoSwitchToolCheckBox->setVisible(tool->isPropertyEnabled(AUTOSWITCHTOOL));
     ui->showInfoBox->setVisible(tool->isPropertyEnabled(SHOWSELECTIONINFO));
 
     auto currentLayerType = editor()->layers()->currentLayer()->type();
@@ -344,6 +348,12 @@ void ToolOptionWidget::setBezier(bool useBezier)
     ui->useBezierBox->setChecked(useBezier);
 }
 
+void ToolOptionWidget::setAutoSwitchTool(bool autoSwitch)
+{
+    QSignalBlocker b(ui->autoSwitchToolCheckBox);
+    ui->autoSwitchToolCheckBox->setChecked(autoSwitch);
+}
+
 void ToolOptionWidget::setShowSelectionInfo(bool showSelectionInfo)
 {
     QSignalBlocker b(ui->showInfoBox);

app/src/tooloptionwidget.h

@@ -65,6 +65,7 @@ public slots:
     void setStabilizerLevel(int);
     void setFillContour(int);
     void setBezier(bool);
+    void setAutoSwitchTool(bool);
     void setShowSelectionInfo(bool);
 
     void disableAllOptions();

app/ui/tooloptions.ui

@@ -130,6 +130,16 @@
         </widget>
        </item>
 
+       <item>
+        <widget class="QCheckBox" name="autoSwitchToolCheckBox">
+         <property name="text">
+          <string>Auto-Switch to Move Tool</string>
+         </property>
+         <property name="checked">
+          <bool>true</bool>
+         </property>
+        </widget>
+       </item>
        <item>
         <widget class="QCheckBox" name="showInfoBox">
          <property name="text">

core_lib/src/managers/toolmanager.cpp

@@ -266,6 +266,11 @@ void ToolManager::setUseFillContour(bool useFillContour)
     emit toolPropertyChanged(currentTool()->type(), FILLCONTOUR);
 }
 
+void ToolManager::setAutoSwitchTool(bool autoSwitch)
+{
+    currentTool()->setAutoSwitchTool(autoSwitch);
+}
+
 void ToolManager::setShowSelectionInfo(bool b)
 {
     currentTool()->setShowSelectionInfo(b);

core_lib/src/managers/toolmanager.h

@@ -80,6 +80,7 @@ public slots:
     void setBucketFillReferenceMode(int referenceMode);
     void setBucketFillExpand(int);
     void setUseFillContour(bool);
+    void setAutoSwitchTool(bool autoSwitch);
     void setShowSelectionInfo(bool b);
     void setShowCameraPath(bool);
     void resetCameraPath();

core_lib/src/tool/basetool.cpp

@@ -444,6 +444,11 @@ void BaseTool::setUseFillContour(const bool useFillContour)
     properties.useFillContour = useFillContour;
 }
 
+void BaseTool::setAutoSwitchTool(const bool autoSwitch)
+{
+    properties.autoSwitchTool = autoSwitch;
+}
+
 void BaseTool::setShowSelectionInfo(const bool b)
 {
     properties.showSelectionInfo = b;

core_lib/src/tool/basetool.h

@@ -55,6 +55,7 @@ class Properties
     bool bucketFillExpandEnabled = 0;
     int bucketFillReferenceMode = 0;
     bool  useFillContour = false;
+    bool autoSwitchTool = true;
     bool  showSelectionInfo = true;
     bool  cameraShowPath = true;
     DotColorType cameraPathDotColorType = DotColorType::RED;
@@ -128,6 +129,7 @@ class BaseTool : public QObject
     virtual void setFillExpandEnabled(const bool enabled);
     virtual void setFillReferenceMode(int referenceMode);
     virtual void setUseFillContour(const bool useFillContour);
+    virtual void setAutoSwitchTool(const bool autoSwitch);
     virtual void setShowSelectionInfo(const bool b);
     virtual void setShowCameraPath(const bool showCameraPath);
     virtual void setPathDotColorType(const DotColorType dotColorType);

core_lib/src/tool/selecttool.cpp

@@ -38,6 +38,8 @@ void SelectTool::loadSettings()
     QSettings settings(PENCIL2D, PENCIL2D);
     properties.showSelectionInfo = settings.value("ShowSelectionInfo").toBool();
     mPropertyEnabled[SHOWSELECTIONINFO] = true;
+    properties.autoSwitchTool = true;
+    mPropertyEnabled[AUTOSWITCHTOOL] = true;
 }
 
 QCursor SelectTool::cursor()
@@ -95,6 +97,11 @@ void SelectTool::setShowSelectionInfo(const bool b)
     settings.setValue("ShowSelectionInfo", b);
 }
 
+bool SelectTool::selectChanging()
+{
+    return mSelectChanging;
+}
+
 void SelectTool::beginSelection()
 {
     auto selectMan = mEditor->select();
@@ -121,6 +128,8 @@ void SelectTool::beginSelection()
 
 void SelectTool::pointerPressEvent(PointerEvent* event)
 {
+    mSelectChanging = true;
+
     mCurrentLayer = mEditor->layers()->currentLayer();
     if (mCurrentLayer == nullptr) return;
     if (!mCurrentLayer->isPaintable()) { return; }
@@ -165,6 +174,8 @@ void SelectTool::pointerMoveEvent(PointerEvent*)
 
 void SelectTool::pointerReleaseEvent(PointerEvent* event)
 {
+    mSelectChanging = false;
+
     mCurrentLayer = mEditor->layers()->currentLayer();
     if (mCurrentLayer == nullptr) return;
     if (event->button() != Qt::LeftButton) return;
@@ -187,6 +198,7 @@ void SelectTool::pointerReleaseEvent(PointerEvent* event)
 
     mStartMoveMode = MoveMode::NONE;
     mSelectionRect = mEditor->select()->mapToSelection(mEditor->select()->mySelectionRect()).boundingRect();
+    editor()->select()->setSelection(mSelectionRect);
 
     mScribbleArea->updateToolCursor();
     mScribbleArea->updateFrame();

core_lib/src/tool/selecttool.h

@@ -39,6 +39,8 @@ class SelectTool : public BaseTool
     void resetToDefault() override;
     void setShowSelectionInfo(const bool b) override;
 
+    bool selectChanging();
+
 private:
 
     void pointerPressEvent(PointerEvent*) override;
@@ -65,6 +67,7 @@ class SelectTool : public BaseTool
     MoveMode mStartMoveMode = MoveMode::NONE;
     QRectF mSelectionRect;
     Layer* mCurrentLayer = nullptr;
+    bool mSelectChanging = false;
 
     QPixmap mCursorPixmap = QPixmap(24, 24);
 };

core_lib/src/util/pencildef.h

@@ -60,6 +60,7 @@ enum ToolPropertyType
     STABILIZATION,
     TOLERANCE,
     FILLCONTOUR,
+    AUTOSWITCHTOOL,
     SHOWSELECTIONINFO,
     USETOLERANCE,
     BUCKETFILLEXPAND,