Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update egg-forge-enhanced.json #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AxcelloHosting
Copy link

Now it shude download the forge server jar as it did not do that before

Now it shude download the forge server jar as it did not do that before
@AxcelloHosting
Copy link
Author

Now it shude download the forge server jar as it did not do that before

@QuintenQVD0
Copy link
Contributor

@AxcelloHosting You messed up the change and overwrote a ptero exported egg on the pelican json file, please fix this asap

@@ -22,7 +21,7 @@
"Java 18": "ghcr.io\/pterodactyl\/yolks:java_18"
},
"file_denylist": [],
"startup": "java -Xms128M -Xmx{{SERVER_MEMORY}}M -Dterminal.jline=false -Dterminal.ansi=true $( [[ ! -f unix_args.txt ]] && printf %s \"-jar {{SERVER_JARFILE}}\" || printf %s \"@unix_args.txt\" )",
"startup": "java -Xms128M -Xmx{{SERVER_MEMORY}}M -Dterminal.jline=false -Dterminal.ansi=true $( [[ ! -f unix_args.txt ]] && printf %s \"-jar .\/libraries\/net\/minecraftforge\/forge\/{{FORGE_VERSION}}\/{{SERVER_JARFILE}}\" || printf %s \"@unix_args.txt\" )",
Copy link

@helio-cat helio-cat Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change (added path) was not necessary in my case. My startup still looks like:
java -Xms128M -Xmx{{SERVER_MEMORY}}M -Dterminal.jline=false -Dterminal.ansi=true $( [[ ! -f unix_args.txt ]] && printf %s "-jar {{SERVER_JARFILE}}" || printf %s "@unix_args.txt" )

I suppose removing the extra whitespace doesn't hurt though.

@helio-cat
Copy link

I just noticed the same problem and was about to do the same pull request :P

The issue seemed to be a bash syntax error due to a missing space which would cause issues with the server.jar file during isntallation.

The install script on line 35

if [ -z ${SERVER_JARFILE}]; then 
  SERVER_JARFILE=server.jar
fi

is missing a space in the IF condition:

if [ -z ${SERVER_JARFILE} ]; then 
  SERVER_JARFILE=server.jar
fi

This was the only fix I needed in my case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants