Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Add Neverwinter Nights: Enhanced Edition #2709

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Add Neverwinter Nights: Enhanced Edition #2709

merged 4 commits into from
Apr 5, 2024

Conversation

RStivanson
Copy link
Contributor

@RStivanson RStivanson commented Jan 31, 2024

Description

Adds an egg for Neverwinter Nights: Enhanced Edition. There was an open PR for this already, but it looks to be stale and broken so I'm opening a new one. Credits go to @NgLoader for the foundations for this though.

I added some extra information on data deployment to the README. There really isn't a ton of documentation on this game anymore it seems, and the info that is there is scattered in the wind. Figured I would consolidate some of it here so people have a good grip on how to get starting playing on the server.

closes #507

One important thing to note is that due to a bug/oversight in the Wings daemon containers are started with an invalid user which causes the server to crash. This egg will only work if you set the environment variables WINGS_UID and WINGS_GID to 1000 and restart your Wings daemon. For context, the server tries to determine its base working directories based on the current user, which is invalid thus causing a segfault.

It's possible that we would want a specific yolk for this instead, similar to the DayZ workaround. Though I figured I would throw this up now where it could be discussed.

Feedback appreciated. Thanks.

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. The egg was exported from the panel

@QuintenQVD0
Copy link
Collaborator

Thank you. There is a fix in PR for the wings that creates a fake /etc/passwd file what will fix this. Its just not yet merged.

@killertobyd
Copy link

Any Updates?

@RStivanson
Copy link
Contributor Author

The egg itself is good to go with the stated workaround, just needs reviewed. I believe this is the wings PR that @QuintenQVD0 was referring to, but doesn't look like it has been merged yet.

@QuintenQVD0
Copy link
Collaborator

I am approving this, it works with the linked wings PR (even that it is closed now and not merged)

Copy link
Collaborator

@QuintenQVD0 QuintenQVD0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuintenQVD0 QuintenQVD0 merged commit f01a016 into pelican-eggs:master Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neverwinter Nights Egg Request
4 participants