remove parenthesed portion of names #559
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was motivated by the following results from a TV series showing up for the query
|
|
I also considered implementing something similar in |
|
I like this! I'm sure it has a downside somewhere, but I think it's worth exploring. Definitely worth kicking off a build. The diff in the Vancouver extract actually looks very positive. |
orangejulius
force-pushed
the
parenthesed-names
branch
from
16d92d1
to
0a0f349
Compare
|
I came across this PR again today and figured we should test it out. Branch is rebased and a planet build is kicked off :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this DRAFT PR is to explore the idea of removing parenthesed portions of names.
I'm not 100% sure this is a great idea, the test cases illustrate some positive and some potentially negative results.