Adding address unit property to import stream #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sweco-semhul
changed the title
stream/address_extractor.js
Outdated
| // copy data to new document | ||
| record = new Document( 'openstreetmap', 'address', newid.join(':') ) | ||
| .setName( 'default', streetno + ' ' + doc.address_parts.street ) | ||
| .setName( 'default', streetno + unit + ' ' + doc.address_parts.street) |
There was a problem hiding this comment.
Hey @sweco-semhul,
Similarly to the OA importer, what do you think about changing this to streetno + street + unit?
|
This looks great, and I believe we can merge it once we talk about the default order of address components (and merge the model and schema changes) |
|
@orangejulius updated the order of street and unit attibute |
michaelkirk
pushed a commit
to michaelkirk-pelias/openstreetmap
that referenced
this pull request
Jun 14, 2023
Update tap-spec to the latest version 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve pelias/pelias#618 more details found in comments to that issue