WIP: skip street parse when its also the subject #1506
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In past work (#1469 and #1468), we've discovered that searching across both the name and
address
fields can be problematic. Records that are a poor name match but also match the address fields can easily outscore a record with an excellent name match.This PR explores another general variant of that situation: times when the Pelias Parser returns the same value as both the
subject
parse and thestreet
parse. By removing thestreet
parse in this case, it looks like there are at least several cases where better POI results are returned.Here's two examples from the acceptance tests, but more investigation into the effects is needed: