Removed unused StateEventHandleFailure (apache#16052)

pegasas · May 23, 2024 · 6862fe7 · 6862fe7
1 parent 56ecec7
commit 6862fe7
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 43 deletions.
diff --git a/...rc/main/java/org/apache/dolphinscheduler/server/master/event/StateEventHandleFailure.java b/...rc/main/java/org/apache/dolphinscheduler/server/master/event/StateEventHandleFailure.java
diff --git a/...ster/src/main/java/org/apache/dolphinscheduler/server/master/event/StateEventHandler.java b/...ster/src/main/java/org/apache/dolphinscheduler/server/master/event/StateEventHandler.java
@@ -28,10 +28,9 @@ public interface StateEventHandler {
      * @param stateEvent given state event.
      * @throws StateEventHandleException this exception means it can be recovered.
      * @throws StateEventHandleError     this exception means it cannot be recovered, so the event need to drop.
-     * @throws StateEventHandleException this means it can be recovered.
      */
     boolean handleStateEvent(WorkflowExecuteRunnable workflowExecuteRunnable,
-                             StateEvent stateEvent) throws StateEventHandleException, StateEventHandleError, StateEventHandleFailure;
+                             StateEvent stateEvent) throws StateEventHandleException, StateEventHandleError;
 
     StateEventType getEventType();
 }
diff --git a/...c/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java b/...c/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
@@ -65,7 +65,6 @@
 import org.apache.dolphinscheduler.server.master.event.StateEvent;
 import org.apache.dolphinscheduler.server.master.event.StateEventHandleError;
 import org.apache.dolphinscheduler.server.master.event.StateEventHandleException;
-import org.apache.dolphinscheduler.server.master.event.StateEventHandleFailure;
 import org.apache.dolphinscheduler.server.master.event.StateEventHandler;
 import org.apache.dolphinscheduler.server.master.event.StateEventHandlerManager;
 import org.apache.dolphinscheduler.server.master.event.TaskStateEvent;
@@ -298,13 +297,6 @@ public void handleEvents() {
                         stateEvent,
                         stateEventHandleException);
                 ThreadUtils.sleep(Constants.SLEEP_TIME_MILLIS);
-            } catch (StateEventHandleFailure stateEventHandleFailure) {
-                log.error("State event handle failed, will move event to the tail: {}",
-                        stateEvent,
-                        stateEventHandleFailure);
-                this.stateEvents.remove(stateEvent);
-                this.stateEvents.offer(stateEvent);
-                ThreadUtils.sleep(Constants.SLEEP_TIME_MILLIS);
             } catch (Exception e) {
                 // we catch the exception here, since if the state event handle failed, the state event will still
                 // keep