Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: issue63: Player Flag Status Added Smart Contract #71

Closed

Conversation

cometsheepboy
Copy link

issue

Currently round ends on timeout or when all players made their turn.

It's quite common for newcomers to drop off the game, hence we would like to modify current logic so that

By default when game starts all players are flagged active
If player did not made any activity previous round, he is flagged as idle
Early turn ending is possible if all active members made their move.
If player made a move and playerMove is called, player must be set back to active
In LibQuadraticVoting function computeScoresByVPIndex should take in list of whether participant proposed or not (infer from is active or not). If is true, the Gives benefits to everyone but himself action must be bypassed.
Flag can be added to LibTurnBasedGame.sol -> struct GameInstance.

The check for early ending can be added to LibTurnBasedGame -> struct canEndTurnEarly

Copy link

changeset-bot bot commented Oct 3, 2024

⚠️ No Changeset found

Latest commit: 53b1464

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cometsheepboy cometsheepboy changed the title issue63: Player Flag Status Added Smart Contract [WIP]: issue63: Player Flag Status Added Smart Contract Oct 3, 2024
@cometsheepboy cometsheepboy deleted the 63-flag-status-added-sol branch October 3, 2024 20:53
@cometsheepboy cometsheepboy restored the 63-flag-status-added-sol branch October 3, 2024 20:59
@cometsheepboy cometsheepboy deleted the 63-flag-status-added-sol branch October 3, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant