[WIP]: issue63: Player Flag Status Added Smart Contract #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
Currently round ends on timeout or when all players made their turn.
It's quite common for newcomers to drop off the game, hence we would like to modify current logic so that
By default when game starts all players are flagged active
If player did not made any activity previous round, he is flagged as idle
Early turn ending is possible if all active members made their move.
If player made a move and playerMove is called, player must be set back to active
In LibQuadraticVoting function computeScoresByVPIndex should take in list of whether participant proposed or not (infer from is active or not). If is true, the Gives benefits to everyone but himself action must be bypassed.
Flag can be added to LibTurnBasedGame.sol -> struct GameInstance.
The check for early ending can be added to LibTurnBasedGame -> struct canEndTurnEarly