Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): use url search params to set default page value #117

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

Hashs7
Copy link
Collaborator

@Hashs7 Hashs7 commented Nov 6, 2024

Set the default page with the user query params ?page=... in the URL.
Fixed for /casos-activos/puntos and /casos-activos/ofertas
Use data.length rather than the count return from supabase, in some case it return 0 and the pagination is not visible

Screen.Recording.2024-11-07.at.00.17.07.mov

@Hashs7 Hashs7 self-assigned this Nov 6, 2024
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 11:19pm

Copy link

supabase bot commented Nov 6, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project nmvcsenkfqbdlfdtiqdo due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@Hashs7 Hashs7 added the bug Something isn't working label Nov 6, 2024
@vsornosa1 vsornosa1 merged commit e78643f into main Nov 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants