Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/forbidden phone number #116

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

Hashs7
Copy link
Collaborator

@Hashs7 Hashs7 commented Nov 6, 2024

Trello task

Add a new rule to don't set the phone number equal to the call center one (626 675 591).
Create a common component to reuse the same phone number everywhere
Transform utils file from js to ts to avoid ts-error-

Screen.Recording.2024-11-06.at.23.44.51.mov

@Hashs7 Hashs7 self-assigned this Nov 6, 2024
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 11:02pm

Copy link

supabase bot commented Nov 6, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project nmvcsenkfqbdlfdtiqdo due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@Hashs7 Hashs7 force-pushed the improvement/forbidden-phone-number branch from bdf87cf to c22ff35 Compare November 6, 2024 23:01
@Hashs7 Hashs7 added the enhancement New feature or request label Nov 6, 2024
Copy link
Collaborator

@vsornosa1 vsornosa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component not needed for the telephone number, but could be refactored in the future as a constant.
Approved.

@vsornosa1 vsornosa1 merged commit 10ff470 into main Nov 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants