Skip to content

Commit

Permalink
Propagate serdeParameters to dwio writer options (facebookincubator#8817
Browse files Browse the repository at this point in the history
)

Summary:
Pull Request resolved: facebookincubator#8817

serdeParameters is not properly propagated to dwio writer. Adding this plumbing to make it propagate.

Reviewed By: Yuhta

Differential Revision: D54027500

fbshipit-source-id: bf9dbc123517d22dfecb90efe3f8e7f5adfecf26
  • Loading branch information
Jialiang Tan authored and facebook-github-bot committed Feb 22, 2024
1 parent 51007ea commit 3bb21d2
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions velox/connectors/hive/HiveDataSink.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,9 @@ uint32_t HiveDataSink::appendWriter(const HiveWriterId& id) {
hiveConfig_->orcWriterMaxStripeSize(connectorSessionProperties));
options.maxDictionaryMemory = std::optional(
hiveConfig_->orcWriterMaxDictionaryMemory(connectorSessionProperties));
options.serdeParameters = std::map<std::string, std::string>(
insertTableHandle_->serdeParameters().begin(),
insertTableHandle_->serdeParameters().end());
ioStats_.emplace_back(std::make_shared<io::IoStatistics>());

// Prevents the memory allocation during the writer creation.
Expand Down

0 comments on commit 3bb21d2

Please sign in to comment.