new plugin testing #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In he last commit, the command updates the json from the registry repo. |
| def on_load(ctx, path): | ||
| with open(ctx.path_to_plugin_file("new", "templates.json")) as fp: | ||
| ctx.TEMPLATES = load(fp) |
There was a problem hiding this comment.
I think we should have a place to store stuff per plugin
There was a problem hiding this comment.
ctx.plugin_store["new"]["TEMPLATES"] ?
There was a problem hiding this comment.
I think one extra parameter called state could be used that is a mix between an object and a dict to have a nicer syntax or maybe ctx.state.new where the state is initialized for each plugin that is registered?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing for the new plugin and template from json on first load.