Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variables PEARL_PKGNAME PEARL_PKGREPONAME #88

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

linkseed
Copy link
Contributor

Correcting the variable value of boot vim.
I think the values of REPONAME and PKGNAME are exchanged.

Thank you for making pearl.

@fsquillace
Copy link
Member

Awesome catch!

Can you please create the pull request with dev as the base branch?

Thanks a lot for this PR!

@fsquillace
Copy link
Member

I have just noticed that this problem occur in emacs boot too: https://github.com/pearl-core/pearl/blob/master/boot/emacs/pearl.el#L5-L6

Can you make the same change in there?

Cheers

@linkseed linkseed changed the base branch from master to dev January 14, 2019 08:15
@linkseed
Copy link
Contributor Author

Can you make the same change in there?

@fsquillace Probably the same kind of correction is good, but I have never used emacs, so I can not check if the modification is correct.

@fsquillace
Copy link
Member

Yes, unfortunately the two boot files vim and emacs are the only ones which are not tested in pearl codebase.

There are also two old issues about that:

If you want you can make the change and I will verify that as soon as it get pushed. Since the branch used here is dev, it will not affect production code. The regex will be the same as the one you used in vim.

Cheers

@fsquillace fsquillace merged commit 646ffd0 into pearl-core:dev Jan 15, 2019
@fsquillace
Copy link
Member

I checked and it works fine in Emacs too.

Thanks again!

@linkseed
Copy link
Contributor Author

I appreciate your generous and prompt response.

@linkseed linkseed deleted the fix_variable_value branch January 15, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants