Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #152 by reducing the text in the symbol index list #292

Closed
wants to merge 2 commits into from

Conversation

thaopham03
Copy link
Contributor

@thaopham03 thaopham03 commented Sep 28, 2023

Fix #152
Reviewed by Moise

@pearcej
Copy link
Owner

pearcej commented Sep 28, 2023

@thaopham03 Please make sure this compiles correctly on your local. Then commit again to this same branch. And, post in the note the Github username of the person who reviewed your pull request.

@thaopham03
Copy link
Contributor Author

@thaopham03 Please make sure this compiles correctly on your local. Then commit again to this same branch. And, post in the note the Github username of the person who reviewed your pull request.

Hello Dr. Jan, I have fixed the issue and complied successfully in my local. Thank you so much!

@pearcej
Copy link
Owner

pearcej commented Sep 28, 2023

@thaopham03 Now you are committing 41 files which are mostly log files. Please update your branch and local then revert your last commit and then ONLY commit the single file that you changed!

@thaopham03 thaopham03 reopened this Sep 28, 2023
@pearcej
Copy link
Owner

pearcej commented Oct 3, 2023

@thaopham03 please update your branch and then notify me

@thaopham03
Copy link
Contributor Author

I have updated my branch Dr. @pearcej

@pearcej
Copy link
Owner

pearcej commented Oct 3, 2023

@thaopham03 Please see the TA. This still has several errors and is not ready. I think you need assistance.

@thaopham03
Copy link
Contributor Author

Close this pull request as it appears to be too messy and not be able to merge onto the main.

@thaopham03 thaopham03 closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the list of symbols, some symbols index too much text
2 participants