Synchronize everything in Transcript #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A long-standing concurrency bug (pcingola#157) was causing get5primeUtrs() to throw ConcurrentModificationException in multithreaded mode. Running with large numbers of cores (96, for instance) exacerbated the problem. A Transcript was being shared between threads, and they were concurrently modifying the utrs member. This change makes all methods synchronized to prevent concurrent use of any of the internals. That might be more synchronization than absolutely necessary, but it appears to solve the problem without a dramatic performance penalty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long-standing concurrency bug (#157) was causing get5primeUtrs() to throw ConcurrentModificationException in multithreaded mode. Running with large numbers of cores (96, for instance) exacerbated the problem.
A Transcript was being shared between threads, and they were concurrently modifying the
utrsmember. This change makes all methods synchronized to prevent concurrent use of any of the internals. That might be more synchronization than absolutely necessary, but itappears to solve the problem without a dramatic performance penalty.