-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Send + Sync
to common traits
#172
Merged
pchampin
merged 22 commits into
pchampin:main
from
mkatychev:feat/send-sync-error-traits
Jul 30, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
4e0af5f
init commit
mkatychev 597327d
revert derive
mkatychev 6fbf401
resource is send + sync
mkatychev 2ff36c9
added threadsafe contracints to resource error
mkatychev 6456ab6
handle xsd::decimal
mkatychev bd10212
Merge branch 'main' into feat/send-sync-error-traits
mkatychev e743625
Merge branch 'knox/downstream' into feat/send-sync-error-traits
mkatychev 64e60f8
updated with feature flag
mkatychev 6d9e1cd
revert imports
mkatychev 7220bf1
macro refer
mkatychev 2a459e2
further updates for error constraint
mkatychev a69cdae
last if dyn Error
mkatychev 5ad320e
revert some dochanges
mkatychev b159d17
clippy
mkatychev 5a741f3
rever dyn decls
mkatychev 773a5ee
cargo fix
mkatychev 6081584
handle LoaderError dyn
mkatychev 33673d7
get rid of ?Sized
mkatychev 265837f
partial revert
mkatychev 5463e52
compiling revert
mkatychev e30b824
clippy lint
mkatychev 47805e1
revert explicit imports
mkatychev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Knowing that this is a breaking change, I held off on explicitly feature flagging unless explicitly requested. This can easily be modified: