-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: set message crash with long error message #622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, just a minor nitpick after I squinted at this classically problematic test suite for a bit
typhos/tests/test_positioner.py
Outdated
|
||
|
||
@pytest.mark.no_gc | ||
def test_positioner_widget_long_status_text(motor_widget, qtbot): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to remind myselfl aoub this no_gc
call (from an earlier CI overhaul), but its usage here jives with my recollection of when and where we were applying this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add qtbot as a fixture argument to this test? We give qtbot the motor widget in fixture construction, and it's not used to waitUntil
or similar in the test body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right, this is probably a copy/paste test case no thinking situation
conda 3.11 passed on a re-run. I know I've recently advocated to not permitting flaky testes but the thought of doing yet another deep dive on this test suite scares me slightly |
We'll definitely need to dive into the flakiness at some point... I might go in eventually and try to make tests simpler whenever possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Motivation and Context
How Has This Been Tested?
Interactively via hotfix + here via unit test
Where Has This Been Documented?
Adding pre-release notes
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page