-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI: Adds Entry pages (BaseParameterPage, NestablePage) #95
Conversation
6fee27b
to
fda0aba
Compare
…, explicitly hint the slot signature
fda0aba
to
27317a6
Compare
superscore/widgets/__init__.py
Outdated
|
||
# a list of qtawesome icon names | ||
icon_map = { | ||
Collection: 'mdi.file-document-multiple', | ||
Parameter: 'msc.symbol-field', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try a few symbol variants? This one is somewhat unintuitive to me. Did something like mdi.file-document
not work for some design reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admittedly didn't think super hard about this, my mind was thinking of Parameters as a "building block" of sorts. But a single mdi.file-document
combining into a Collection (file-document-multiple) makes a lot of sense, I was blind to the obvious thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's certainly a bit closer than I'd like but I'm not sure
There's also an outline variant we could try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked some questions but things look reasonable
I wasn't able to fully test myself because I couldn't get an editable entry page to appear from superscore's ui
A quick icon change, then I think we can get this in |
Description
Adds Pages for viewing and editing details for the other entry types.
BaseParameterPage
which dynamically shows and hides widgets based on which fields are present (Single PV Entries)This is currently based on top of #96 , once that's in I'll rebase one last time
Motivation and Context
#65
#66
#67
#68
How Has This Been Tested?
I'll add tests I swear
Where Has This Been Documented?
This PR
A readback (has tolerances, no rbv)
A setpoint (no tolerances, has rbv)
Widgets update based on pv type
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page