ENH: add skeleton mainpage and dialogs #75
Conversation
|
Seems like we're missing some ui files? |
There was a problem hiding this comment.
A few more fixups then I think we're close enough to merge!
If we had more time I'd be more of a stickler for type hints and docstrings, but we can address that in a followup.
Nice work, and thanks for all your efforts over the course of this internship Marisa! 🎉
| pass | ||
|
|
||
| def open_filter_menu(self): | ||
| self.filter = FilterMenu() |
There was a problem hiding this comment.
| self.filter = FilterMenu() | |
| self.filter = FilterMenu(parent=self) | |
| self.filter.setWindowFlag(QtCore.Qt.Dialog) |
Generally with qt you should give widgets parents, so that if their parent is deleted the child gets cleaned up as well. This also helps garbage collection not accidentally delete the widget prematurely.
If you want to preserve the pop-out-window functionality you add the proper WindowFlag (you'll have to import QtCore.Qt.Dialog one way or another)
| self.filter.show() | ||
|
|
||
| def open_load_config(self): | ||
| self.loadPage = LoadScreen() |
There was a problem hiding this comment.
Same with the previous comment (parent and window flag)
| pass | ||
|
|
||
| def open_save_page(self): | ||
| self.savePage = SaveScreen() |
There was a problem hiding this comment.
Same here (parent and window flag)
| def tree_set_up(self): | ||
| pass | ||
|
|
||
| def refresh_table(self, newParameters): |
There was a problem hiding this comment.
If we had more time, I'd ask for some type hints or docstrings throughout the diff here to communicate what we intend these methods to be used for. It may be obvious to you now, but in the future whoever is implementing these would surely appreciate breadcrumbs to follow
|
|
||
|
|
||
| class LoadScreen(Display, QtWidgets.QDialog): | ||
| filename = "load_snapshot_dialog.ui" |
Co-authored-by: Robert Tang-Kong <[email protected]>
snake casing Co-authored-by: Robert Tang-Kong <[email protected]>
Description
This PR includes 4 screens, ui and and accompanying skeleton .py file for: Main page with snapshot view, filters dialog, save dialog, and load configuration dialog screens.
Motivation and Context
This is an implementation of the GUI mockups, from MIRO, and start of creating desired workflow.
The Main page contains 3 functioning buttons (which load dialog screens) as well as skeleton .py with future functionally in mind; such as tree model-view for collections and table model-view for displaying snapshots. The dialog pages load and also contain placeholders for future implementation of tree-view and table-view for making selections (filter selections and saving selections).
How Has This Been Tested?
Interactively
Where Has This Been Documented?
In this PR
Screenshots (if appropriate):
Main page with snapshot view:
Filter screen:
Load config:
Save config:
Pre-merge checklist
docs/pre-release-notes.shand created a pre-release documentation page