Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: check both dataclass and EntryItem in tree view in canFetchMore #114

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tangkong
Copy link
Contributor

Description

Previously RootTree.canFetchMore would check the dataclass members to determine if filling was necessary. This works within the context of a single page, but if we open the a detailed page from the tree-view the dataclass may be filled without the EntryItem getting filled.

Now that RootTree.canFetchMore checks both the dataclass and the EntryItem, this desync can be avoided

Motivation and Context

Closes #113

How Has This Been Tested?

Interactively

Where Has This Been Documented?

This PR, pre-release notes

Pre-merge checklist

  • Code works interactively
  • Code follows the style guide
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@tangkong tangkong force-pushed the bug_tree_fetchmore_page_open branch from 9cbe390 to 1dc70bc Compare December 11, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: expanding tree view entry shows data with no titles or descriptions
1 participant