BUG: check both dataclass and EntryItem in tree view in canFetchMore
#114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously
RootTree.canFetchMore
would check the dataclass members to determine if filling was necessary. This works within the context of a single page, but if we open the a detailed page from the tree-view the dataclass may be filled without the EntryItem getting filled.Now that
RootTree.canFetchMore
checks both the dataclass and theEntryItem
, this desync can be avoidedMotivation and Context
Closes #113
How Has This Been Tested?
Interactively
Where Has This Been Documented?
This PR, pre-release notes
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page