Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: move context menu functionality upstream into RootTreeView #107

Merged
merged 8 commits into from
Dec 3, 2024

Conversation

tangkong
Copy link
Contributor

Description

  • Adds common RootTreeView which holds the RootTree model
    • Upstreams standard settings and context menu support
  • Fills the top-level entry whenever RootTree model is created, to ensure at least first level of children display

Motivation and Context

Closes #101

How Has This Been Tested?

Interactively, and some tests have been added

Now you can double-click-to-open and right-click inside of other pages that have Tree Views
Now all pages with tree views will open with at least the first set of children populated.

Where Has This Been Documented?

This PR

image

Pre-merge checklist

  • Code works interactively
  • Code follows the style guide
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@tangkong tangkong requested a review from shilorigins December 3, 2024 18:32
Copy link
Collaborator

@shilorigins shilorigins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@tangkong tangkong merged commit 557b55f into pcdshub:master Dec 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI: upstream context menu / click handling for Root Tree
2 participants