Support for arrays of strings

[KaushikMalapati]

Meant to close #327. I made two small changes for this to work

• In from chain, I moved the data_type.is_string in front of the data_type.is_array or chain.last.array_info so that arrays will not use WaveformRecordPackage.
• I handle string arrays as a complex type instead of a non-complex type so that a pv is made for each array index

[tangkong]

Conda test failures seem unrelated, we need to add setuptools to the recipe since it's no longer implicit
https://github.com/pcdshub/pytmc/actions/runs/12101972735/job/33797497583?pr=332#step:12:216

[tangkong]

This looks reasonable to me but I will defer to Zach here.

[KaushikMalapati]

Conda test failures seem unrelated, we need to add setuptools to the recipe since it's no longer implicit https://github.com/pcdshub/pytmc/actions/runs/12101972735/job/33797497583?pr=332#step:12:216

Do I just add setuptools to the run requirements in meta.yaml for this?

[tangkong]

Yes, but I would prefer we make a new PR for this as to be very clear when we modify build recipes. See our other python repos for example conda recipes (we added setuptools_scm gradually as we noticed these errors iirc)
https://github.com/pcdshub/pcdsdevices/blob/6a4e36fbeed085ee3f34ee327a41fcc9e9e7eae4/conda-recipe/meta.yaml#L21

[ZLLentz]

The changes here make sense in principle but this sort of thing really needs a unit test.

For example, what about adding this new case to the parameterization in

pytmc/pytmc/tests/test_xml_collector.py

Lines 94 to 111 in c30a7c9

	@pytest.mark.parametrize(
	"tc_type, is_array, final_type",
	[
	("BOOL", False, BinaryRecordPackage),
	("BOOL", True, WaveformRecordPackage),
	("INT", False, IntegerRecordPackage),
	("INT", True, WaveformRecordPackage),
	("DINT", False, IntegerRecordPackage),
	("DINT", True, WaveformRecordPackage),
	("ENUM", False, EnumRecordPackage),
	("ENUM", True, WaveformRecordPackage),
	("REAL", False, FloatRecordPackage),
	("REAL", True, WaveformRecordPackage),
	("LREAL", False, FloatRecordPackage),
	("LREAL", True, WaveformRecordPackage),
	("STRING", False, StringRecordPackage),
	],
	)

(just as one example)

I wonder if there are other places in the test suite that make sense to extend to check the new feature. Perhaps it's worth adding something later in this test_xml_collector near where we check other kinds of "complex" arrays?

I'm not exactly sure what this looks like in practice but the lack of testing is the thing that stands out most here.

[ZLLentz]

I like the tests you added a lot!

I'm going to click "update branch" and if it passes we should merge this!

[ZLLentz]

This is a good expansion of our IOC gen capabilities.