Making ExitSlits subclass with FDQ component, only for SL1K2 for now

[KaushikMalapati]

Description

ExitSlitsFDQ has an FDQ component so we can see flow meter readings on the typhos screen for SL1K2. I did not name this SL1K2 in case an ExitSlits+FDQ class is ever wanted in the future

Motivation and Context

https://jira.slac.stanford.edu/browse/ECS-6745

How Has This Been Tested?

Where Has This Been Documented?

Pre-merge checklist

• Code works interactively
• Code contains descriptive docstrings, including context and API
• New/changed functions and methods are covered in the test suite where possible
• Test suite passes locally
• Test suite passes on GitHub Actions
• Ran docs/pre-release-notes.sh and created a pre-release documentation page
• Pre-release docs include context, functional descriptions, and contributors as appropriate

[KaushikMalapati]

@nrwslac with pcdshub/lcls-plc-rixs-optics#133 merged, can you please review this?

[KaushikMalapati]

@ZLLentz could you look at this error log for the pip jobs?
https://github.com/pcdshub/pcdsdevices/actions/runs/12167562079/job/33936947300?pr=1307
I haven't changed anything that would affect attenuators, but it might have something to do with the test changes you made recently

[ZLLentz]

could you look at this error log for the pip jobs
I haven't changed anything that would affect attenuators

I agree this has nothing to do with your code
I'll look a little more closely to see if I can understand what's going on, but I don't remember making test changes here recently. I might have modified the ci templates though...

[KaushikMalapati]

...but I don't remember making test changes here recently. I might have modified the ci templates though...
For some reason this file says it was changed 8 days ago but the last commit was on January 31

[ZLLentz]

For some reason this file says it was changed 8 days ago but the last commit was on January 31

That's really bizarre. I feel less bad about not remembering a change from Jan/Feb than I do about not remembering a change from last week!

[ZLLentz]

We can either merge #1311 first or merge this with bypassing the failing tests

[KaushikMalapati]

We can either merge #1311 first or merge this with bypassing the failing tests

Let's wait for #1311

[ZLLentz]

#1311 is merged so I'll click update branch here, anticipating green check marks all around

[tangkong]

✅

[KaushikMalapati]

@nrwslac I added the doc string and think this is ready. If you think it's good, I will merge and update the device_class for sl1k2

[KaushikMalapati]

Actually, I took a second look at this. Did you want the FDQ to be in ExitSlits directly instead of a subclass?

[KaushikMalapati]

I decided to add the flow meter to ExitSlits directly. sl1k2 is the only device that uses the class so it didn't make sense to me to subclass it.

[tangkong]

I believe you are correct. Currently SL1K2 is the only consumer of this class. This does make the requirements for implementing this class more strict in the future, but we can cross that bridge when we get there (perhaps this motivates us to add these flow monitors, in a backwards sort of way)