Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing imprecise TPR_TICK_NS constant #1306

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

KaushikMalapati
Copy link
Contributor

@KaushikMalapati KaushikMalapati commented Nov 9, 2024

Description

Changing TPR_TICK_NS from 5.384 to 70/13. 5.384 is imprecise enough to cause large errors in _get_delay used by TprMotor.readback.get() and TprTrigger.ns_delay.get().

Motivation and Context

#1302

How Has This Been Tested?

Interactively (The error was due to a misspelling)
image

Where Has This Been Documented?

Pre-release notes

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@KaushikMalapati KaushikMalapati marked this pull request as ready for review November 9, 2024 00:32
Copy link
Contributor

@slactjohnson slactjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only comment I have here is that it would be good to include a comment describing this strange fraction and what the approximate value is.

Copy link
Contributor

@slactjohnson slactjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding comments. LGTM.

@KaushikMalapati KaushikMalapati merged commit c5060c8 into pcdshub:master Nov 11, 2024
11 checks passed
@KaushikMalapati KaushikMalapati deleted the getdelay branch November 11, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants