Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 'scaling factor' for the micronix stage (Det_X) was found to be incorrect due to a mistake in the pre-checkout worksheet (wrong encoder model selected). The encoded Kohzu stages (Jet_X,Y,Z) motor parameters were similarly adjusted using Nick's 'step counting' technique.Motivation and Context
The stages would consistently stall during move requests greater than ~1mm.How Has This Been Tested?
The changes were tested at the MFX beamline with the actual stages, by comparing move requests with displacement measurements, using a micrometer.Where Has This Been Documented?
Screenshots (if appropriate):
Pre-merge checklist
Always Newest
pre-commit
(alternativelypre-commit run --all-files
)