Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motor tuning #7

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Motor tuning #7

merged 5 commits into from
Nov 15, 2024

Conversation

rcjwoods
Copy link
Contributor

@rcjwoods rcjwoods commented Nov 6, 2024

Improved settings for LiquidJet motor stages

Description

The 'scaling factor' for the micronix stage (Det_X) was found to be incorrect due to a mistake in the pre-checkout worksheet (wrong encoder model selected). The encoded Kohzu stages (Jet_X,Y,Z) motor parameters were similarly adjusted using Nick's 'step counting' technique.

Motivation and Context

The stages would consistently stall during move requests greater than ~1mm.

How Has This Been Tested?

The changes were tested at the MFX beamline with the actual stages, by comparing move requests with displacement measurements, using a micrometer.

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • [ x] Code works interactively
  • [ x] Code contains descriptive comments
  • [ x] Test suite passes locally
  • [ x] Libraries are set to fixed versions and not Always Newest
  • [ x] Code committed with pre-commit (alternatively pre-commit run --all-files)

@c-tsoi c-tsoi requested a review from NSLentz November 6, 2024 23:37
@c-tsoi
Copy link

c-tsoi commented Nov 6, 2024

Committing so that Russ can pull commit and fixing merge issues.

Copy link
Contributor

@NSLentz NSLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but looks like PR is still in draft so I will hold off on approving.
Please add a description to the PR and document what has been done. Then move out of draft mode when ready for final review.

@rcjwoods rcjwoods marked this pull request as ready for review November 8, 2024 00:58
@rcjwoods rcjwoods requested a review from NSLentz November 8, 2024 00:59
Copy link
Contributor

@NSLentz NSLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you. Feel free to merge.

@rcjwoods rcjwoods merged commit 563ac9d into pcdshub:master Nov 15, 2024
9 checks passed
@rcjwoods rcjwoods deleted the motor_tuning branch November 15, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants