Joshc slac/ecseng 565 #44
Conversation
| @@ -307,7 +307,7 @@ XPP_DS_Gauge.rPRESS := XPP_Downstream_Gauge.rPRESS;//XPP_Modbus_Gauge.VG.rPRESS; | |||
| i_sDevName:= 'BT2L0:PLEG:VGC:01', | |||
| iq_stValve=> , | |||
| xMPS_OK=> , | |||
| io_fbFFHWO:= g_FastFaultOutput1, | |||
| io_fbFFHWO:= g_FastFaultOutput1, // TODO(josh): ask maggie if this is sufficient because we have connected the FF | |||
| {attribute 'pytmc' := ' | ||
| pv: PLC:LFE:VAC:FFO:04 | ||
| '} | ||
| g_FastFaultOutput4 : FB_HardwareFFOutput :=(i_sNetID:='172.21.88.66.1.1'); //FFO for ST1L0_XTES's Downstream Components |
There was a problem hiding this comment.
The comment is confusing. The new FFO is for the valves in the section that is downstream of the optics and upstream of ST1L1 on the L1 line.
| @@ -352,7 +352,7 @@ XPP_DS_Gauge.rPRESS := XPP_Downstream_Gauge.rPRESS;//XPP_Modbus_Gauge.VG.rPRESS; | |||
| i_sDevName:= 'TV1L1:VGC:01', | |||
| iq_stValve=> , | |||
| xMPS_OK=> , | |||
| io_fbFFHWO:= g_FastFaultOutput1, | |||
| io_fbFFHWO:= g_FastFaultOutput1, // TODO(josh): ask maggie if this is sufficient because we have connected the FF | |||
There was a problem hiding this comment.
This one should be linked to the new FFO that has the optics veto evaluation
| @@ -103,7 +99,7 @@ | |||
| <Resolution>LCLS Vacuum, 2.3.0 (SLAC - LCLS)</Resolution> | |||
| </PlaceholderResolution> | |||
| <PlaceholderResolution Include="PMPS"> | |||
| <Resolution>PMPS, 3.0.14 (SLAC - LCLS)</Resolution> | |||
| <Resolution>PMPS, * (SLAC - LCLS)</Resolution> | |||
There was a problem hiding this comment.
Please make sure to set the effective version on the libraries. it has to point to a specific version and not set to newest.
There was a problem hiding this comment.
lcls-plc-lfe-vac/plc_lfe_vac/plc_lfe_vac/plc_lfe_vac/plc_lfe_vac.plcproj
Lines 159 to 161 in 6c6c489
There was a problem hiding this comment.
https://docs.google.com/presentation/d/1moIDgnQtO2f7veBoTfxUGaALhq8NSwQulQrYihWgLtE/edit?usp=sharing
From slides 39 and 40 I believe I did it correctly, though I see what you are calling out. Let me know if theres a way not enumerated in the documentation to do this
There was a problem hiding this comment.
The Library shouldn't have been upgraded to the latest. Should have remained the same. I am seeing issues because of this now. You mentioned that these changes are deployed, But now i see that they aren't.
joshc-slac
force-pushed
the
joshc-slac/ECSENG-565
branch
from
bea2b68 to
d101fdc
Compare
| @@ -307,7 +307,7 @@ XPP_DS_Gauge.rPRESS := XPP_Downstream_Gauge.rPRESS;//XPP_Modbus_Gauge.VG.rPRESS; | |||
| i_sDevName:= 'BT2L0:PLEG:VGC:01', | |||
| iq_stValve=> , | |||
| xMPS_OK=> , | |||
| io_fbFFHWO:= g_FastFaultOutput1, | |||
| io_fbFFHWO:= g_FastFaultOutput4, // TODO(josh): ask maggie if this is sufficient because we have connected the FF | |||
There was a problem hiding this comment.
@ghalym you called out the one below, my assumption is this one also needed to be updated.
Description
By adding a veto device as specified in scenario 1 from the docs such that we can logically ignore the faults when L1 is not receiving beam.
Motivation and Context
We are currently bypassing a fault that is not meaningful. Adding this as a veto device allows us to keep our faults meaningful and the system safer.
How Has This Been Tested?
Ideally today
Where Has This Been Documented?
Not yet
Screenshots (if appropriate):
Pre-merge checklist
Always Newestpre-commit(alternativelypre-commit run --all-files)