ENH: Adding --update feature to epicsarch-qs (in progress) #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vespos
reviewed
Oct 6, 2023
hutch_python/epics_arch.py
Outdated
| 'archFIle.') | ||
| 'archFile.') | ||
|
|
||
| parser.add_argument('--update', action='store_true', default=False, |
There was a problem hiding this comment.
I dont think we need that argument, it serves the same purpose as --dry-run (in fact it does the exact opposite). We always want to update the existing file, never overwrite it fully.
There was a problem hiding this comment.
Sounds good! I am working on this now
…e, removed print statements
…d epicsArchChecker from engineering tools to hutch python. Had to change from epicsArchChecker to epicsArchChecker.py to get the module recognizable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am currently working on adding an --update feature that looks at the current hutches epicsArch file and compares it to the questionnaire. It looks for instances of duplicate PVs and if this occurs then it will take the alias from the questionnaire instance and replace it for the one in the local epicsArch file.
Motivation and Context
This change helps to prevent duplicating PV entries across the arch files, ensures we have the most current information from the questionnaire and gives us another option besides overwriting the current file.
How Has This Been Tested?
Untested/Still in progress. (Going on vacation and want to update progress)
Where Has This Been Documented?
N/A
Pre-merge checklist
docs/pre-release-notes.shand created a pre-release documentation page