-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV/MNT: migrate to GitHub Actions and pyproject.toml [LCLSPC-603] #358
Conversation
Performed by pcds-migration-tools DeleteFiles
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools GitHubActionsMigration
Performed by pcds-migration-tools UpdateSphinx
Performed by pcds-migration-tools RunPyupgrade
Performed by pcds-migration-tools PyprojectTomlMigration
Performed by pcds-migration-tools SetuptoolsScmMigration
Performed by pcds-migration-tools UpdateCondaRecipe
Performed by pcds-migration-tools RunPycln
Performed by pcds-migration-tools PrecommitAutoupdate
One test consistently failing: Some other weird output in the log, but discussed in side channels it's probably intentional-ish |
This might be the same test that's been failing? #354 (yep https://app.travis-ci.com/github/pcdshub/hutch-python/jobs/588574480#L1011) This also probably closes #335 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can fix that test in a differently scoped PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 All of these migration PRs are starting to blur together
(Merging and bypassing branch restrictions; reviewers indicated that IPython-related bug should be solved in a separate PR) |
Description
pyproject.toml
, replacingsetup.py
and related files.pyupgrade
.docs-versions-menu
replacesdoctr-versions-menu
anddoctr
usage for documentation deployment on GitHub Actions. The deployment key is now no longer required.pyupgrade
was used to update annotations.pycln
was used to clean up importsMotivation and Context
How Has This Been Tested?
Where Has This Been Documented?
This PR and Jira LCLSPC-603