Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: make tst_pim_2 loadable, types.SimpleNamespace does not take positional args #349

Merged
merged 2 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
349 bug_args_simplenamespace
############################

API Breaks
----------
- N/A

Features
--------
- N/A

Bugfixes
--------
- Fixes issue in test suite, making tst_base_pim2 a loadable SimpleNamespacce

Maintenance
-----------
- N/A

Contributors
------------
- tangkong
3 changes: 0 additions & 3 deletions happi/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -429,9 +429,6 @@ def db(tmp_path):
"tst_base_pim2": {
"_id": "tst_base_pim2",
"active": true,
"args": [
"{{prefix}}"
],
"beamline": "TST",
"creation": "Wed Jan 30 09:46:00 2019",
"device_class": "types.SimpleNamespace",
Expand Down
4 changes: 1 addition & 3 deletions happi/tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,7 @@ def test_search_json(runner: CliRunner, happi_cfg: str):
{
"name": "tst_base_pim2",
"device_class": "types.SimpleNamespace",
"args": [
"{{prefix}}"
],
"args": [],
"kwargs": {
"name": "{{name}}"
},
Expand Down