-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH/REF: Modify FillTemplatePage to have staging area #239
Conversation
…rom previous refactor
…FillTemplatePage to reflect new ui layout
…walk_tree_items to avoid circular imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always find it really hard to review atef
I had a comment and a docs nitpick
I'll try to run this myself to play qa bugfinder
@@ -56,7 +58,7 @@ def verify_file_and_notify( | |||
bool | |||
the verification success | |||
""" | |||
verified, msg = file.verify() | |||
verified, msg = file.validate() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this unknowingly broken for a few days?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes 😢 . My ctrl+f did not ctrl+f enough it seems
I'm not sure how to make this better. atef is complicated but I think the web of signals and slots tends to make things opaque. I've often wondered what it would take to make the atef development process more clear... |
Design thoughts and nitpicks:
|
"no obvious bugs" has to be an all-time high for me 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 👍 on this design update
Great, thanks! I'm going to merge this and forge ahead with the GUI elements that fold this into the main checkouts. |
Description
FillTemplatePage
, to be more clear about which changes are being queued for applicationMotivation and Context
In looking into reusing
FillTemplatePage
for templated checkouts, it became clear that the page needed a refactorFillTemplatePage
would maintain an internal "all actions" list and a user could apply them gradually. This made the current state of the loaded checkout ambiguous (had we applied changes yet?)FindReplaceAction
) saved in a templated checkout would need to be loaded without knowledge of the search query that produced it.FillTemplatePage
would gather all actions in any populated edit when asked to apply all. The user would either have to know that these were the right actions or click through them all to verifyHow Has This Been Tested?
Entirely interactively so far. But the test suite passes
Where Has This Been Documented?
This PR.
Compare to before:
Details
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page