Fix: make footprint display configurable app-wide

- note: requires full ui-defaults object in config
pc2 · Mar 14, 2024 · 849b7e0 · 849b7e0
1 parent 82f5257
commit 849b7e0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/internal/config/config.go b/internal/config/config.go
@@ -31,6 +31,7 @@ var Keys schema.ProgramConfig = schema.ProgramConfig{
 		"job_view_nodestats_selectedMetrics":     []string{"flops_any", "mem_bw", "mem_used"},
 		"job_view_polarPlotMetrics":              []string{"flops_any", "mem_bw", "mem_used"},
 		"job_view_selectedMetrics":               []string{"flops_any", "mem_bw", "mem_used"},
+		"job_view_showFootprint":                 true,
 		"plot_general_colorBackground":           true,
 		"plot_general_colorscheme":               []string{"#00bfff", "#0000ff", "#ff00ff", "#ff0000", "#ff8000", "#ffff00", "#80ff00"},
 		"plot_general_lineWidth":                 3,

diff --git a/web/frontend/src/Job.root.svelte b/web/frontend/src/Job.root.svelte
@@ -65,6 +65,7 @@
 
   let isMetricsSelectionOpen = false,
     selectedMetrics = [],
+    showFootprint = true,
     isFetched = new Set();
   const [jobMetrics, startFetching] = fetchMetricsStore();
   getContext("on-init")(() => {
@@ -77,6 +78,9 @@
         .find((c) => c.name == job.cluster)
         .metricConfig.map((mc) => mc.name);
 
+    showFootprint =
+      ccconfig[`job_view_showFootprint`]
+
     let toFetch = new Set([
       "flops_any",
       "mem_bw",
@@ -209,7 +213,7 @@
       <Spinner secondary />
     {/if}
   </Col>
-  {#if $jobMetrics.data}
+  {#if $jobMetrics.data && showFootprint}
     {#key $jobMetrics.data}
       <Col>
         <JobFootprint