Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated readme #46

wants to merge 1 commit into from

Conversation

bes89
Copy link

@bes89 bes89 commented Aug 2, 2015

added bower install highlightjs and used ---save parameter when installing packages

added bower install highlightjs and used ---save parameter when installing packages
@pc035860
Copy link
Owner

pc035860 commented Aug 3, 2015

There's no --save nor --save-dev presented at https://github.com/angular-ui/ui-router/blob/master/README.md#get-started.
I believe they meant to let the user to decide whether to add it or not?

@bes89
Copy link
Author

bes89 commented Aug 3, 2015

Whats wrong with --save? it just adds the new dependency to your package.json/bower.json.
Sure, you can add it manually....

@ethanhann
Copy link

Installing highlightjs separately wouldn't be necessary if it is listed in angular-highlightjs's bower.json file as a dependency.

@pc035860
Copy link
Owner

@ethanhann Actually, the highlight.js dependency was removed from bower.json due to #28 .

@ethanhann
Copy link

Ah, I understand the situation. Dependencies can be overridden in bower.json anyway, which is handy for allowing tools like wiredep to work, so it isn't a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants