Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close settings modal on save #34

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

XiNiHa
Copy link
Contributor

@XiNiHa XiNiHa commented Aug 31, 2024

Closes the settings modal when the save button is clicked

@XiNiHa XiNiHa requested a review from pbzweihander as a code owner August 31, 2024 02:27
@@ -32,6 +32,7 @@ export default function RightNavSetting({

const onSubmit: SubmitHandler<PutSettingReq> = (data) => {
putSetting(data);
modalRef.current?.close();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어 뭔가 스페이스랑 탭 문자가 섞인 것 같은데 고쳐주실 수 있을까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엌 수정했습니다

@XiNiHa XiNiHa force-pushed the feat/close-settings-on-save branch from 15ba944 to b098ec9 Compare August 31, 2024 05:01
@pbzweihander pbzweihander merged commit 339ea78 into pbzweihander:main Aug 31, 2024
5 checks passed
@XiNiHa XiNiHa deleted the feat/close-settings-on-save branch August 31, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants