Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel fix #28

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Kernel fix #28

merged 4 commits into from
Nov 21, 2023

Conversation

danieltherealyang
Copy link
Contributor

No description provided.

Aplet123
Aplet123 requested changes Nov 19, 2023
View reviewed changes
Copy link
Member

@Aplet123 Aplet123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old version was correct; this version introduces a bug where the page table is no longer where the C code believes it is, thus breaking palloc and also failing to unmap the lower half addresses (which is why it made the idt start working again)

@bliutech bliutech merged commit c0f2556 into main Nov 21, 2023
2 checks passed
@bliutech bliutech deleted the kernel_fix branch November 21, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aplet123 Aplet123 Aplet123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieltherealyang @Aplet123 @bliutech