Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appraisal & Combustion; Rails 3, 6, & 7 Compat fixes #105

Merged
merged 51 commits into from
Apr 25, 2024

📝 Improved documentation

134b8aa
Select commit
Loading
Failed to load commit list.
Merged

Appraisal & Combustion; Rails 3, 6, & 7 Compat fixes #105

📝 Improved documentation
134b8aa
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 25, 2024 in 0s

88.88% (-0.74%) compared to 756e786, passed because coverage increased by +0.44% when compared to adjusted base (88.44%)

View this Pull Request on Codecov

88.88% (-0.74%) compared to 756e786, passed because coverage increased by +0.44% when compared to adjusted base (88.44%)

Details

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 88.88%. Comparing base (756e786) to head (134b8aa).

Files Patch % Lines
lib/sanitize_email.rb 94.59% 2 Missing ⚠️
lib/sanitize_email/overridden_addresses.rb 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   89.61%   88.88%   -0.74%     
==========================================
  Files           8        8              
  Lines         289      297       +8     
  Branches       97      104       +7     
==========================================
+ Hits          259      264       +5     
- Misses         30       33       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.