-
-
Notifications
You must be signed in to change notification settings - Fork 36
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Appraisal & Combustion; Rails 3, 6, & 7 Compat fixes (#105)
* 🧑💻 Default to No DEBUG=true * 👷 Setup Appraisal * 👷 Attempt to use custom RuboCop version * 👷 Unspecify rubygems version for old Ruby + Rails combos * 👷 Remove rubygems version for old Ruby + Rails combos * 👷 Specify old bundler version for old Ruby + Rails combos * 👷 Experimental true for finicky bundler/rubygems combos * 🚨 Lint lock * 👷 RAILS_VERSION * 👷 RAILS_MAJOR_MINOR * 👷 Ancient Rails Support * 👷 Fix names * 💚 Fix test * 💚 Fix test * 💚 Fix tests * 💚 Fix env variables * 💚 Fix env variables * 💚 Fix rdoc version * 💚 Allow JSON Version for Rails 4 support * 💚 consolidate on matrix.rails * ✨ Combustion Test Rails App * ✨ Combustion Testing * 👷 Combustion Testing * 💚 Fix dependency version pins * 💚 Fix code coverage * 🔨 Regenerate Appraisals * ➖ Min branch cov = 72% * 🔧 Fix path to gemspec * ➖ rspec-rails * ➖ actionpack * ✅ Add back Rails 3.0-, 3.1, 3.2 * 📌 rake v10 for ancient Appraisals * 📌 tzinfo v1 for ancient Rails * 📌 delivery_method :test for Rails 3 * 📌 undefined method `unparsed_value' for #<Mail::OptionalField> on Rails 3 * 📌 branch coverage @ 71% * 📌 undefined method `unparsed_value' for #<Mail::OptionalField> on Rails 3 * 💚 Fix test on Rails 3 * 💚 Fix typo * 🚨 Lint lock * 👷 Turn off experimental CI flags * 👷 prefer block_is_expected * 🔥 Remove bogus comment * 🔥 Remove bogus comments * 📝 Improve documentation * 🚨 Disable RSpec/ExampleLength * 📝 Documentation * 🔧 89% coverage * 🔖 Prepare release v2.0.6 * 🚨 Lint lock * 📝 Improved documentation
- Loading branch information
Showing
53 changed files
with
1,037 additions
and
531 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,11 @@ | ||
| ### External Testing Controls | ||
| export K_SOUP_COV_DO=true # Means you want code coverage | ||
| export K_SOUP_COV_MIN_BRANCH=71 # Means you want to enforce X% branch coverage | ||
| export K_SOUP_COV_MIN_LINE=90 # Means you want to enforce X% line coverage | ||
| export K_SOUP_COV_MIN_LINE=89 # Means you want to enforce X% line coverage | ||
| export K_SOUP_COV_MIN_HARD=true # Means you want the build to fail if the coverage thresholds are not met | ||
| # Available formats are html, xml, rcov, lcov, json, tty | ||
| export K_SOUP_COV_MULTI_FORMATTERS="html,tty" # What coverage output formats do you want? | ||
| export MAX_ROWS=5 # Setting for simplecov-console gem for tty output, limits to the worst N rows of bad coverage | ||
| export DEBUG=true # allow byebug statements | ||
| # export DEBUG=true # allow byebug statements | ||
| export RAILS_VERSION="~> 7.1" | ||
| export RAILS_MAJOR_MINOR=7.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| name: Rails 3 - 4.1 on EOL Ruby 2.3 | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - 'main' | ||
| - '*-stable' | ||
| - '*-dev' | ||
| tags: | ||
| - '!*' # Do not execute on tags | ||
| pull_request: | ||
| branches: | ||
| - '*' | ||
| # Allow manually triggering the workflow. | ||
| workflow_dispatch: | ||
|
|
||
| # Cancels all previous workflow runs for the same branch that have not yet completed. | ||
| concurrency: | ||
| # The concurrency group contains the workflow name and the branch name. | ||
| group: "${{ github.workflow }}-${{ github.ref }}" | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Specs - Ruby ${{ matrix.ruby }} & Rails ${{ matrix.rails }} ${{ matrix.name_extra || '' }} | ||
| if: "!contains(github.event.commits[0].message, '[ci skip]') && !contains(github.event.commits[0].message, '[skip ci]')" | ||
| env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps | ||
| BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile | ||
| # rspec-rails uses RAILS_VERSION internally | ||
| RAILS_VERSION: "~> ${{ matrix.rails }}" | ||
| # Our spec suite (not runtime code) uses RAILS_MAJOR_MINOR internally | ||
| RAILS_MAJOR_MINOR: ${{ matrix.rails }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - ruby: "2.3" | ||
| appraisal: "rails-4-1" | ||
| bundler: '1.17.3' | ||
| gemfile: vanilla | ||
| rails: "4.1" | ||
| - ruby: "2.3" | ||
| appraisal: "rails-4-0" | ||
| bundler: '1.17.3' | ||
| gemfile: vanilla | ||
| rails: "4.0" | ||
| - ruby: "2.3" | ||
| appraisal: "rails-3-2" | ||
| bundler: '1.17.3' | ||
| gemfile: vanilla | ||
| rails: "3.2" | ||
| - ruby: "2.3" | ||
| appraisal: "rails-3-1" | ||
| bundler: '1.17.3' | ||
| gemfile: vanilla | ||
| rails: "3.1" | ||
| - ruby: "2.3" | ||
| appraisal: "rails-3-0" | ||
| bundler: '1.17.3' | ||
| gemfile: vanilla | ||
| rails: "3.0" | ||
| runs-on: ubuntu-20.04 | ||
| continue-on-error: ${{ matrix.experimental || endsWith(matrix.ruby, 'head') }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Setup Ruby & RubyGems | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: ${{ matrix.ruby }} | ||
| rubygems: ${{ matrix.rubygems }} | ||
| bundler: ${{ matrix.bundler }} | ||
| bundler-cache: false | ||
| # This will use the BUNDLE_GEMFILE set to matrix.gemfile (i.e. vanilla) | ||
| # We need to do this first to get appraisal installed. | ||
| # NOTE: This does not use the root Gemfile at all. | ||
| - name: Bundle for Appraisal ${{ matrix.appraisal }} (Rails v${{ matrix.rails}}) | ||
| run: bundle _1.17.3_ install | ||
| - name: Install Appraisal ${{ matrix.appraisal }} (Rails v${{ matrix.rails}}) dependencies | ||
| run: bundle _1.17.3_ exec appraisal ${{ matrix.appraisal }} bundle _1.17.3_ install | ||
| - name: Run tests ${{ matrix.appraisal }} (Rails v${{ matrix.rails}}) | ||
| run: bundle _1.17.3_ exec appraisal ${{ matrix.appraisal }} bundle _1.17.3_ exec rake test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.