Skip to content

Commit

Permalink
Platform/ARM: Fix BootMonFS device path
Browse files Browse the repository at this point in the history
The NOR Flash driver was recently moved from the Tianocore\edk2 repository
to the Tianocore\edk2-platforms repository at the following location:
Platform\ARM\Drivers\NorFlashDxe\NorFlashDxe.inf

As part of this move the FILE_GUID for the NorFlashDxe.inf at the new
location was also updated from: 93E34C7E-B50E-11DF-9223-2443DFD72085
to: DE6AE758-D662-4E17-A97C-4C5964DA4C41

Correspondingly, the device paths for the BootMonFs also requires to be
updated in gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths
so that the file system is correctly mounted.

Therefore, update the BootMonFS device path for the platforms that
utilise it.

Reported-by: Sudeep Holla <[email protected]>
Signed-off-by: Sami Mujawar <[email protected]>
Tested-by: Sudeep Holla <[email protected]>
  • Loading branch information
samimujawar authored and ardbiesheuvel committed Feb 3, 2023
1 parent 878c4b1 commit c855d03
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Platform/ARM/JunoPkg/ArmJuno.dec
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
gArmJunoTokenSpaceGuid.PcdSynopsysUsbEhciBaseAddress|0x7FFC0000|UINT32|0x00000005

# Juno Device Trees are loaded from NOR Flash
gArmJunoTokenSpaceGuid.PcdJunoFdtDevicePath|L"VenHw(93E34C7E-B50E-11DF-9223-2443DFD72085,00)/board.dtb"|VOID*|0x00000008
gArmJunoTokenSpaceGuid.PcdJunoFdtDevicePath|L"VenHw(DE6AE758-D662-4E17-A97C-4C5964DA4C41,00)/board.dtb"|VOID*|0x00000008

# MHU Register base used by SCMI Mailbox transport
gArmJunoTokenSpaceGuid.PcdArmMtlDoorBell|0x2B1F0000|UINT64|0x00000024
Expand Down
2 changes: 1 addition & 1 deletion Platform/ARM/JunoPkg/ArmJuno.dsc
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@
gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|24

# List of Device Paths that support BootMonFs
gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L"VenHw(93E34C7E-B50E-11DF-9223-2443DFD72085,00)"
gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L"VenHw(DE6AE758-D662-4E17-A97C-4C5964DA4C41,00)"

#
# ARM Architectural Timer Frequency
Expand Down
2 changes: 1 addition & 1 deletion Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@


# List of Device Paths that support BootMonFs
gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L"VenHw(93E34C7E-B50E-11DF-9223-2443DFD72085,00)"
gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L"VenHw(DE6AE758-D662-4E17-A97C-4C5964DA4C41,00)"

# ARM OS Loader
gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3
Expand Down
2 changes: 1 addition & 1 deletion Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@
#
# Define the device path to the FDT for the platform
#
gFdtPlatformDxeTokenSpaceGuid.PcdFdtDevicePaths|L"VenHw(93E34C7E-B50E-11DF-9223-2443DFD72085,00)/ca15a7"
gFdtPlatformDxeTokenSpaceGuid.PcdFdtDevicePaths|L"VenHw(DE6AE758-D662-4E17-A97C-4C5964DA4C41,00)/ca15a7"

#
# ARM Architectural Timer Frequency
Expand Down
2 changes: 1 addition & 1 deletion Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@
#

# List of Device Paths that support BootMonFs
gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L"VenHw(93E34C7E-B50E-11DF-9223-2443DFD72085,00);VenHw(93E34C7E-B50E-11DF-9223-2443DFD72085,02)"
gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L"VenHw(DE6AE758-D662-4E17-A97C-4C5964DA4C41,00);VenHw(DE6AE758-D662-4E17-A97C-4C5964DA4C41,02)"

# RunAxf support via Dynamic Shell Command protocol
# We want to use the Shell Libraries but don't want it to initialise
Expand Down

0 comments on commit c855d03

Please sign in to comment.