Added global and local ignore path rewriting support to path configurations #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveshanley
reviewed
Jun 14, 2024
| pterm.Println() | ||
|
|
||
| for _, ignoreRewrite := range ignoreRewritePaths { | ||
| pterm.Printf("🙅 Paths matching '%s' will not be re-written regardless of Path Rewrite configuration\n", pterm.LightCyan(ignoreRewrite.Path)) |
There was a problem hiding this comment.
hahaha. another win with the emoji!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wiretap just blindly rewrites paths that match any configuration.
Some (poorly written) APIs don't necessarily want to rewrite everything under a specific resource location.
The current way to do this is to add a dummy path rewrite that takes precedence. This is kind of hacky and also doesn't jump over target rewriting.
This MR adds first party support for ignoring path rewriting on these unintended endpoints.