Added request information to all non-schema validation errors #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveshanley
approved these changes
Apr 11, 2024
|
@daveshanley Thanks Dave, just rebased. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
- Coverage 98.96% 97.68% -1.28%
==========================================
Files 19 19
Lines 1156 1731 +575
==========================================
+ Hits 1144 1691 +547
- Misses 12 40 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jacobm-splunk
force-pushed
the
jacobm/added-request-info-to-validation-error
branch
from
f4047ea
to
a5a7cc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some request information to the validation error struct.
Rather than modifying this in constructors, I figured it would be a lot easier to populate this as the last step during validation. If that's not the right approach, I can convert it to a constructor oriented method.