feat: Accessibility Automated failing tests fix (DTCRCMERC-3548) #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cycode-security[bot]](https://avatars.githubusercontent.com/in/39308?s=60&v=4){kind=small}
perco12
approved these changes
Sep 25, 2024
erikacolette29
merged commit 42d88b7
into
paypal:playwright-automated-testing
58 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For our modals, our accessibility scan was failing with the best-practice tag which is required for our accessibility scans.
US and DE long term modals heading levels are not in the correct order. Our fix is to change our level heading order from h2 to h4, with h2 to h3.
In messages tests, our accessibility scan is looking for a landmark, however since it is evaluating just our messages, there is no need for a landmark since the message will be on a merchant site. Also our message button opens a modal that has landmarks. This rule can be ignored.
'landmark-one-main'In our message tests, our accessibility scan is looking for a level one heading. However since we are just evaluating our messages, this rule can be ignored. The page the message will be on will have a level one heading, also when our message button is clicked it opens a modal with the correct heading levels.
'page-has-heading-one'Screenshots
Testing instructions