Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Visa Account Funding Transactions #9

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add support for Visa Account Funding Transactions #9

wants to merge 8 commits into from

Conversation

tjconcept
Copy link
Member

No description provided.

@tjconcept tjconcept requested a review from LarsBoThomsen June 28, 2023 08:09
addic
addic reviewed Jul 5, 2023
View reviewed changes
payments/index.md Outdated
name: String, // optional, length: 1..1024
address: String, // optional, length: 1..1024
city: String, // optional, length: 1..1024
state: String, // optional, length: 1..1024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe at least the state (as is the country) should be expected as {2,2}?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds reasonable..

Copy link
Member Author

@tjconcept tjconcept Jul 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I changed it to be an actual ISO code instead:

The second part is a string of up to three alphanumeric characters

The stricter requirements for AFTs (two letters) is valid for US and CA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addic addic addic left review comments

@LarsBoThomsen LarsBoThomsen LarsBoThomsen approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjconcept @LarsBoThomsen @addic