Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix \ and $ escape error in VSCode snippet #22

Closed
wants to merge 2 commits into from
Closed

Fix \ and $ escape error in VSCode snippet #22

wants to merge 2 commits into from

Conversation

sabertazimi
Copy link

Examples

VSCode JSON snippet => true output

  • "\\" => ""
  • "\\\\" => "\"
  • "\\begin" => "\begin"
  • "\$" => "$"
  • "\$abc" => "$abc"
  • "\\\$" => "$"
  • "\\\$abc" => "$abc"
  • "\\\\\$" => "\$"
  • "\\\\\$abc" => "\$abc"

@pawelgrzybek
Copy link
Owner

Hi.

I finally had a chance to review your PR. You did an amazing job and I am really thankful for your time, effort and research. It fixes the issue #13 but unfortunately introduces a new issue. Because you target all $ it escapes placeholders too. The syntax for placeholder is $1, $2, $3 or ${1:name}, ${2:surname}, ${1:age}. It breaks this feature.

I am closing this one for now and feel free to resubmit if you have a fixed implementation.

Thanks a lot and have a nice weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants